fix(vue-app): middleware not executing on double browser back navigation #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsonpoindexter
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #6775 +/- ##
==========================================
- Coverage 64.82% 64.75% -0.08%
==========================================
Files 78 78
Lines 2718 2721 +3
Branches 706 708 +2
==========================================
Hits 1762 1762
- Misses 729 730 +1
- Partials 227 229 +2
Continue to review full report at Codecov.
|
|
Actually this makes sense, even if I cannot reproduce it on my machine (might be too fast). Can you reproduce this on your slower machine when running |
|
@Atinux yes, I am able to reproduce this in production mode. |
jeremybradbury
previously approved these changes
Dec 18, 2019
Atinux
changed the title
pi0
force-pushed
the
dev
branch
2 times, most recently
from
007c785
to
a84f31d
Compare
# Conflicts: # packages/vue-app/template/server.js
pi0
approved these changes
Mar 13, 2020
|
Thanks @jsonpoindexter |
Merged
This was referenced Mar 20, 2020
This was referenced Mar 28, 2020
This was referenced Apr 8, 2020
This was referenced Apr 9, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When a Nuxt app is in Universal mode it is possible that in some cases a component's middleware does not execute.
This can happen when a user first navigates to a project page (example: Page B), server.js executes and then before client.js executes the user navigates to another page in the project (example: Page A). In this scenario https://github.com/nuxt/nuxt.js/blob/dev/packages/vue-app/template/client.js#L810 will evaluate to
TRUEand not execute the middleware(s) for page A.Resolves: https://cmty.app/nuxt/nuxt.js/issues/c10049 / #6716
Checklist:
I could not find a way to programmatically reproduce this issue ie. changes routes after server.js has executed, but before client.js executes.